Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use initialPosition on init #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use initialPosition on init #274

wants to merge 1 commit into from

Conversation

rjruizes
Copy link

During initialization, setCenter is called twice:

  1. by React, initialized to (0,0)
  2. by InteractableView, initialized to the initialPosition

Occasionally, the second event is not received on the react-native side (#269). This PR makes the first event initialize to the initialPosition.

@chinmaygit
Copy link

When this PR is going to merge ?
looks like very important.

@rjruizes
Copy link
Author

@rotemmiz Could you review please?

@alisherakb
Copy link

alisherakb commented Jul 16, 2019 •
edited
Loading

@rjruizes
When setting animatedNativeDriver={true} it gives an error:

AnimatedEvent is not a function (near '...})(event, gestureState ...')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjruizes @chinmaygit @alisherakb